From b9e248be3262327af30c54441d522b96a1e17705 Mon Sep 17 00:00:00 2001
From: Noah Masur <7386960+nmasur@users.noreply.github.com>
Date: Thu, 21 Oct 2021 11:17:51 -0400
Subject: [PATCH] Revert "evaluate gpp upstream on cli"

This reverts commit e4b6c3c9ba73f8cd27aa7094082f1162a16351e0.
---
 bin/git_set_upstream                 | 12 ++++++++++++
 fish.configlink/functions/abbrs.fish |  4 ++--
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100755 bin/git_set_upstream

diff --git a/bin/git_set_upstream b/bin/git_set_upstream
new file mode 100755
index 0000000..553f3c8
--- /dev/null
+++ b/bin/git_set_upstream
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+# Copied from David Pedersen: https://github.com/davidpdrsn/dotfiles/blob/master/bin/git-pp
+
+set -e
+
+git_branch_name() {
+  val=$( git branch 2>/dev/null | grep '^\*' | colrm 1 2 )
+  echo "$val"
+}
+
+git push --set-upstream origin "$(git_branch_name)"
diff --git a/fish.configlink/functions/abbrs.fish b/fish.configlink/functions/abbrs.fish
index 20abe91..8e42bfd 100644
--- a/fish.configlink/functions/abbrs.fish
+++ b/fish.configlink/functions/abbrs.fish
@@ -30,7 +30,7 @@ function abbrs --description 'All abbreviations'
     abbr -a gca 'git commit --amend'
     abbr -a gu 'git pull'
     abbr -a gp 'git push'
-    abbr -a gpp git push --set-upstream origin (git branch 2>/dev/null | grep '^\*' | colrm 1 2)
+    abbr -a gpp 'git_set_upstream'
     abbr -a gl 'git log --graph --decorate --oneline -20'
     abbr -a gll 'git log --graph --decorate --oneline'
     abbr -a gco 'git checkout'
@@ -43,7 +43,7 @@ function abbrs --description 'All abbreviations'
     abbr -a grh 'git reset --hard'
     abbr -a gm 'git merge'
     abbr -a gcp 'git cherry-pick'
-    abbr -a cdg cd (git rev-parse --show-toplevel)
+    abbr -a cdg 'cd (git rev-parse --show-toplevel)'
 
     # GitHub
     abbr -a ghr 'gh repo view -w'