client samba cleanup

modules/nixos/hardware/networking.nix

@@ -9,6 +9,8 @@
     networking.interfaces.enp5s0.useDHCP = true;
     networking.interfaces.wlp4s0.useDHCP = true;
 
+    networking.firewall.allowPing = lib.mkIf config.server true;
+
   };
 
 }

modules/nixos/services/samba.nix

@@ -7,7 +7,7 @@
     services.samba = lib.mkIf (config.samba.enable) {
       enable = true;
       openFirewall = true;
-      shares.video = {
+      shares.data = {
         path = "/data";
         browseable = "yes";
         "read only" = "no";
@@ -18,15 +18,20 @@
       };
     };
 
-    # Allow browsing Samba shares
+    # Allows Windows clients to discover server
+    services.samba-wsdd.enable = true;
+    networking.firewall.allowedTCPPorts = [ 5357 ];
+    networking.firewall.allowedUDPPorts = [ 3702 ];
+
+    # Allow client browsing Samba and virtual filesystem shares
     services.gvfs =
       lib.mkIf (config.gui.enable && config.nautilus.enable) { enable = true; };
 
-    # Permissions required to mount Samba with GVFS, if not using desktop environment
-    environment.systemPackages = lib.mkIf (config.gui.enable
-      && config.nautilus.enable
-      && config.services.xserver.windowManager.i3.enable)
-      [ pkgs.lxqt.pxqt-policykit ];
+    # # Permissions required to mount Samba with GVFS, if not using desktop environment
+    # environment.systemPackages = lib.mkIf (config.gui.enable
+    #   && config.nautilus.enable
+    #   && config.services.xserver.windowManager.i3.enable)
+    #   [ pkgs.lxqt.lxqt-policykit ];
 
   };